netdev - Re: [PATCH v2 net-next 2/8] net: move sk->sk_err_soft and sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUBvKFLNc9DHMikByVzFVc9bp_AHw5rpEnZre5-69sL_4w@mail.gmail.com>
Date: Mon, 22 Sep 2025 16:36:07 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Neal Cardwell <ncardwell@...gle.com>, Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 2/8] net: move sk->sk_err_soft and sk->sk_sndbuf

On Fri, Sep 19, 2025 at 1:49 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> sk->sk_sndbuf is read-mostly in tx path, so move it from
> sock_write_tx group to more appropriate sock_read_tx.
>
> sk->sk_err_soft was not identified previously, but
> is used from tcp_ack().
>
> Move it to sock_write_tx group for better cache locality.
>
> Also change tcp_ack() to clear sk->sk_err_soft only if needed.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>