netdev - Re: [PATCH net] bnxt_en: correct offset handling for IPv6 destination address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOBf=ms2MMk7dMiEH+V04QR_F=YusDOw6K_BH2htLODziRUKcg@mail.gmail.com>
Date: Mon, 22 Sep 2025 08:24:52 +0530
From: Somnath Kotur <somnath.kotur@...adcom.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: netdev@...r.kernel.org, michael.chan@...adcom.com, 
	pavan.chebbi@...adcom.com, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org
Subject: Re: [PATCH net] bnxt_en: correct offset handling for IPv6 destination address

On Sat, Sep 20, 2025 at 5:42 PM Alok Tiwari <alok.a.tiwari@...cle.com> wrote:
>
> In bnxt_tc_parse_pedit(), the code incorrectly writes IPv6
> destination values to the source address field (saddr) when
> processing pedit offsets within the destination address range.
>
> This patch corrects the assignment to use daddr instead of saddr,
> ensuring that pedit operations on IPv6 destination addresses are
> applied correctly.
>
> Fixes: 9b9eb518e338 ("bnxt_en: Add support for NAT(L3/L4 rewrite)")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> index d72fd248f3aa..2d66bf59cd64 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
> @@ -244,7 +244,7 @@ bnxt_tc_parse_pedit(struct bnxt *bp, struct bnxt_tc_actions *actions,
>                            offset < offset_of_ip6_daddr + 16) {
>                         actions->nat.src_xlate = false;
>                         idx = (offset - offset_of_ip6_daddr) / 4;
> -                       actions->nat.l3.ipv6.saddr.s6_addr32[idx] = htonl(val);
> +                       actions->nat.l3.ipv6.daddr.s6_addr32[idx] = htonl(val);
>                 } else {
>                         netdev_err(bp->dev,
>                                    "%s: IPv6_hdr: Invalid pedit field\n",
> --
> 2.50.1
>
Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>