netdev - Re: [PATCH net-next 05/20] net, ynl: Implement netdev_nl_bind_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc473610-4a3b-46a4-b875-df945032a909@davidwei.uk>
Date: Tue, 23 Sep 2025 09:06:34 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>,
 Stanislav Fomichev <stfomichev@...il.com>
Cc: Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, davem@...emloft.net, razor@...ckwall.org,
 pabeni@...hat.com, willemb@...gle.com, sdf@...ichev.me,
 john.fastabend@...il.com, martin.lau@...nel.org, jordan@...fe.io,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com
Subject: Re: [PATCH net-next 05/20] net, ynl: Implement
 netdev_nl_bind_queue_doit

On 2025-09-22 18:26, Jakub Kicinski wrote:
> On Mon, 22 Sep 2025 09:06:51 -0700 Stanislav Fomichev wrote:
>>> +	priv = genl_sk_priv_get(&netdev_nl_family, NETLINK_CB(skb).sk);
>>> +	if (IS_ERR(priv))
>>> +		return PTR_ERR(priv);
>>
>> Why do you need genl_sk_priv_get and mutex_lock?
> 
> +1
> 
> Also you're taking the instance lock on two netdev instances,
> how will this not deadlock? :$

Yeah... Sorry, we'll need to rethink locking in this function.