lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ec3a75bd-8879-4832-aad1-0e2aa096ec5e@davidwei.uk>
Date: Tue, 23 Sep 2025 09:13:46 -0700
From: David Wei <dw@...idwei.uk>
To: Jakub Kicinski <kuba@...nel.org>, Daniel Borkmann <daniel@...earbox.net>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
 razor@...ckwall.org, pabeni@...hat.com, willemb@...gle.com, sdf@...ichev.me,
 john.fastabend@...il.com, martin.lau@...nel.org, jordan@...fe.io,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com
Subject: Re: [PATCH net-next 01/20] net, ynl: Add bind-queue operation

On 2025-09-22 18:17, Jakub Kicinski wrote:
> On Fri, 19 Sep 2025 23:31:34 +0200 Daniel Borkmann wrote:
>> Subject: [PATCH net-next 01/20] net, ynl: Add bind-queue operation
> 
> We use "ynl" for changes to ynl itself. If you're just adding to
> the YAML specs or using them there's no need to mention YNL.
> Please remove in all the subjects.
> 
>> +  -
>> +    name: queue-pair
>> +    attributes:
>> +      -
>> +        name: src-ifindex
>> +        doc: netdev ifindex of the physical device
>> +        type: u32
>> +        checks:
>> +          min: 1
> 
> max: s32-max ?
> 
>> +      -
>> +        name: src-queue-id
>> +        doc: netdev queue id of the physical device
>> +        type: u32
> 
> 
>> @@ -772,6 +795,20 @@ operations:
>>             attributes:
>>               - id
>>   
>> +    -
>> +      name: bind-queue
>> +      doc: Bind a physical netdev queue to a virtual one
> 
> Would be good to have a few sentences of documentation here.
> All netdev APIs currently carry queue id with type.
> I'm guessing the next few patches would explain but whether
> you're attaching rx, tx, or both should really be explained here :)

Got it, will expand the docs.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ