netdev - Re: [PATCH net 08/10] can: esd_usb: Fix not detecting version reply in probe routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922171626.2ebb1e30@kernel.org>
Date: Mon, 22 Sep 2025 17:16:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Marc Kleine-Budde <mkl@...gutronix.de>
Cc: netdev@...r.kernel.org, davem@...emloft.net, linux-can@...r.kernel.org,
 kernel@...gutronix.de, Stefan Mätje <stefan.maetje@....eu>
Subject: Re: [PATCH net 08/10] can: esd_usb: Fix not detecting version reply
 in probe routine

On Mon, 22 Sep 2025 12:07:38 +0200 Marc Kleine-Budde wrote:
> +	do {
> +		int actual_length;
> +		int pos;
> +
> +		err = usb_bulk_msg(dev->udev,
> +				   usb_rcvbulkpipe(dev->udev, 1),
> +				   rx_buf,
> +				   ESD_USB_RX_BUFFER_SIZE,
> +				   &actual_length,
> +				   ESD_USB_DRAIN_TIMEOUT_MS);
> +		dev_dbg(&dev->udev->dev, "AT %d, LEN %d, ERR %d\n", attempt, actual_length, err);
> +		++attempt;
> +		if (err)
> +			goto bail;
> +		if (actual_length == 0)
> +			continue;

continue in do-while loops doesn't check the condition.
This looks like a potential infinite loop?