netdev - Re: [PATCH net-next v3 03/15] quic: provide common utilities and data structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250923090641.GE836419@horms.kernel.org>
Date: Tue, 23 Sep 2025 10:06:41 +0100
From: Simon Horman <horms@...nel.org>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, quic@...ts.linux.dev,
	davem@...emloft.net, kuba@...nel.org,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Stefan Metzmacher <metze@...ba.org>,
	Moritz Buhl <mbuhl@...nbsd.org>,
	Tyler Fanelli <tfanelli@...hat.com>,
	Pengtao He <hepengtao@...omi.com>, linux-cifs@...r.kernel.org,
	Steve French <smfrench@...il.com>,
	Namjae Jeon <linkinjeon@...nel.org>,
	Paulo Alcantara <pc@...guebit.com>, Tom Talpey <tom@...pey.com>,
	kernel-tls-handshake@...ts.linux.dev,
	Chuck Lever <chuck.lever@...cle.com>,
	Jeff Layton <jlayton@...nel.org>,
	Benjamin Coddington <bcodding@...hat.com>,
	Steve Dickson <steved@...hat.com>, Hannes Reinecke <hare@...e.de>,
	Alexander Aring <aahringo@...hat.com>,
	David Howells <dhowells@...hat.com>,
	Matthieu Baerts <matttbe@...nel.org>,
	John Ericson <mail@...nericson.me>,
	Cong Wang <xiyou.wangcong@...il.com>,
	"D . Wythe" <alibuda@...ux.alibaba.com>,
	Jason Baron <jbaron@...mai.com>, illiliti <illiliti@...tonmail.com>,
	Sabrina Dubroca <sd@...asysnail.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Daniel Stenberg <daniel@...x.se>,
	Andy Gospodarek <andrew.gospodarek@...adcom.com>
Subject: Re: [PATCH net-next v3 03/15] quic: provide common utilities and
 data structures

On Thu, Sep 18, 2025 at 06:34:52PM -0400, Xin Long wrote:

> index f79f43f0c17f..b54532916aa2 100644
> --- a/net/quic/protocol.c
> +++ b/net/quic/protocol.c
> @@ -336,6 +336,9 @@ static __init int quic_init(void)
>  	if (err)
>  		goto err_percpu_counter;
>  
> +	if (quic_hash_tables_init())

Hi Xin,

If we reach here then the function will return err, which is 0.
So it seems that err should be set to a negative error value instead.
Perhaps the return value of quic_hash_tables_init.

Flagged by Smatch.


> +		goto err_hash;
> +
>  	err = register_pernet_subsys(&quic_net_ops);
>  	if (err)
>  		goto err_def_ops;
> @@ -353,6 +356,8 @@ static __init int quic_init(void)
>  err_protosw:
>  	unregister_pernet_subsys(&quic_net_ops);
>  err_def_ops:
> +	quic_hash_tables_destroy();
> +err_hash:
>  	percpu_counter_destroy(&quic_sockets_allocated);
>  err_percpu_counter:
>  	return err;

...