netdev - Re: [PATCH net-next v2 04/14] dibs: Register smc as dibs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94bfc71a-178d-435d-b54a-117e8265f532@redhat.com>
Date: Tue, 23 Sep 2025 11:09:24 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Alexandra Winter <wintera@...ux.ibm.com>,
 "D. Wythe" <alibuda@...ux.alibaba.com>, Dust Li <dust.li@...ux.alibaba.com>,
 Sidraya Jayagond <sidraya@...ux.ibm.com>, Wenjia Zhang
 <wenjia@...ux.ibm.com>, David Miller <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>
Cc: Julian Ruess <julianr@...ux.ibm.com>,
 Aswin Karuvally <aswin@...ux.ibm.com>, Halil Pasic <pasic@...ux.ibm.com>,
 Mahanta Jambigi <mjambigi@...ux.ibm.com>, Tony Lu
 <tonylu@...ux.alibaba.com>, Wen Gu <guwen@...ux.alibaba.com>,
 linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
 linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev
 <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>, Simon Horman <horms@...nel.org>,
 Eric Biggers <ebiggers@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 Harald Freudenberger <freude@...ux.ibm.com>,
 Konstantin Shkolnyy <kshk@...ux.ibm.com>
Subject: Re: [PATCH net-next v2 04/14] dibs: Register smc as dibs_client

On 9/16/25 10:37 AM, Alexandra Winter wrote:
> On 16.09.25 09:40, Paolo Abeni wrote:
>> On 9/11/25 9:48 PM, Alexandra Winter wrote:
>>> diff --git a/net/smc/Kconfig b/net/smc/Kconfig
>>> index ba5e6a2dd2fd..40dd60c1d23f 100644
>>> --- a/net/smc/Kconfig
>>> +++ b/net/smc/Kconfig
>>> @@ -1,7 +1,7 @@
>>>  # SPDX-License-Identifier: GPL-2.0-only
>>>  config SMC
>>>  	tristate "SMC socket protocol family"
>>> -	depends on INET && INFINIBAND
>>> +	depends on INET && INFINIBAND && DIBS
>>>  	depends on m || ISM != m
>>>  	help
>>>  	  SMC-R provides a "sockets over RDMA" solution making use of
>>
>> DIBS is tristate, and it looks like SMC build will fail with SMC=y and
>> DIBS=m. I *think* you additionally need something alike:
>>
>> 	depends on m || DIBS != m
>> 	
>> /P
>>
> 
> 
> My understanding of 'SMC depends on DIBS' is that DIBS has to have
> a higher or equal state than SMC (with y > m > n).

You are right, I got lost in dependency hell, sorry.

LGTM!

/P