netdev - Re: [PATCHv2 net 2/2] selftests: bonding: add ipsec offload test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aNJklbSInqqIkfK9@fedora>
Date: Tue, 23 Sep 2025 09:12:53 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, Jay Vosburgh <jv@...sburgh.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
	Shuah Khan <shuah@...nel.org>, Petr Machata <petrm@...dia.com>,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCHv2 net 2/2] selftests: bonding: add ipsec offload test

On Tue, Sep 23, 2025 at 10:32:22AM +0200, Paolo Abeni wrote:
> > +lib_dir=$(dirname "$0")
> > +source "$lib_dir"/../../../net/lib.sh
> > +algo="aead rfc4106(gcm(aes)) 0x3132333435363738393031323334353664636261 128"
> > +srcip=192.0.2.1
> > +dstip=192.0.2.2
> > +ipsec0=/sys/kernel/debug/netdevsim/netdevsim0/ports/0/ipsec
> > +ipsec1=/sys/kernel/debug/netdevsim/netdevsim0/ports/1/ipsec
> > +active_slave=""
> > +
> > +active_slave_changed()
> > +{
> > +        local old_active_slave=$1
> > +        local new_active_slave=$(ip -n ${ns} -d -j link show bond0 | \
> > +				 jq -r ".[].linkinfo.info_data.active_slave")
> 
> shell check is not super happy about the lack of double quotes  around
> the variables (above and many places below) and about declaring the
> variable and assigning it to a subshell in the same statement.
> 
> I think it's better to address such warnings for consistency.

Ah, this is a patch I wrote some times ago. I forgot to re-format it with
shellcheck. I will fix the warnings.

Thanks
hangbin