netdev - Re: [PATCH v18 07/20] sfc: create type2 cxl memdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75e09b73-e44e-40bf-8d9e-c20809694829@amd.com>
Date: Wed, 24 Sep 2025 09:56:39 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Dave Jiang <dave.jiang@...el.com>, alejandro.lucero-palau@....com,
 linux-cxl@...r.kernel.org, netdev@...r.kernel.org, dan.j.williams@...el.com,
 edward.cree@....com, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, edumazet@...gle.com
Cc: Martin Habets <habetsm.xilinx@...il.com>, Fan Ni <fan.ni@...sung.com>,
 Edward Cree <ecree.xilinx@...il.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v18 07/20] sfc: create type2 cxl memdev


On 9/19/25 20:58, Dave Jiang wrote:
>
> On 9/19/25 8:59 AM, Dave Jiang wrote:
>>
>> On 9/18/25 2:17 AM, alejandro.lucero-palau@....com wrote:
>>> From: Alejandro Lucero <alucerop@....com>
>>>
>>> Use cxl API for creating a cxl memory device using the type2
>>> cxl_dev_state struct.
>>>
>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>> Reviewed-by: Martin Habets <habetsm.xilinx@...il.com>
>>> Reviewed-by: Fan Ni <fan.ni@...sung.com>
>>> Acked-by: Edward Cree <ecree.xilinx@...il.com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>
>> with a nit below.
>>
>>> ---
>>>   drivers/net/ethernet/sfc/efx_cxl.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
>>> index 651d26aa68dc..177c60b269d6 100644
>>> --- a/drivers/net/ethernet/sfc/efx_cxl.c
>>> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
>>> @@ -82,6 +82,12 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>>>   		return dev_err_probe(&pci_dev->dev, -ENODEV,
>>>   				     "dpa capacity setup failed\n");
>>>   
>>> +	cxl->cxlmd = devm_cxl_add_memdev(&pci_dev->dev, &cxl->cxlds, NULL);
>>> +	if (IS_ERR(cxl->cxlmd)) {
>>> +		pci_err(pci_dev, "CXL accel memdev creation failed");
>> As Jonathan mentioned. Maybe dev_err() to keep it consistent.
> Hmm....looking at the rest of the driver files the pci_*() calls are used instead. So ignore my comment. Although typically device drivers use dev_*() calls and pci_*() calls are reserved for PCI core devices.
>
> DJ
>    


Hi Dave,


It is true the sfc driver is using pci_err and not dev_err* but I have 
been using dev_err in the sfc cxl code from the beginning, and I do not 
think there is a problem with that at all, so as I commented in a 
previous patch, I'll keep the consistency with previous error reports in 
this file.


Thanks


>>> +		return PTR_ERR(cxl->cxlmd);
>>> +	}
>>> +
>>>   	probe_data->cxl = cxl;
>>>   
>>>   	return 0;
>>