netdev - Re: [PATCH 3/3] ns: drop assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25byqesyh4xqu4j7trvq3rkz2kkr6ej7eblami6wf2kat5aymm@jt3cfzkgawgj>
Date: Wed, 24 Sep 2025 14:00:20 +0200
From: Jan Kara <jack@...e.cz>
To: Christian Brauner <brauner@...nel.org>
Cc: linux-fsdevel@...r.kernel.org, Amir Goldstein <amir73il@...il.com>, 
	Josef Bacik <josef@...icpanda.com>, Jeff Layton <jlayton@...nel.org>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering <mzxreary@...inter.de>, 
	Aleksa Sarai <cyphar@...har.com>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Jan Kara <jack@...e.cz>, Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>, 
	Michal Koutný <mkoutny@...e.com>, Jakub Kicinski <kuba@...nel.org>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker <frederic@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, cgroups@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] ns: drop assert

On Wed 24-09-25 13:34:00, Christian Brauner wrote:
> Otherwise we warn when e.g., no namespaces are configured but the
> initial namespace for is still around.
> 
> Signed-off-by: Christian Brauner <brauner@...nel.org>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  kernel/nscommon.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/nscommon.c b/kernel/nscommon.c
> index 92c9df1e8774..c1fb2bad6d72 100644
> --- a/kernel/nscommon.c
> +++ b/kernel/nscommon.c
> @@ -46,8 +46,6 @@ static void ns_debug(struct ns_common *ns, const struct proc_ns_operations *ops)
>  		VFS_WARN_ON_ONCE(ops != &utsns_operations);
>  		break;
>  #endif
> -	default:
> -		VFS_WARN_ON_ONCE(true);
>  	}
>  }
>  #endif
> 
> -- 
> 2.47.3
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR