netdev - Re: [PATCH net 09/10] can: esd_usb: Fix handling of TX context objects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e810a325d0652a3b709807d2fbd7f8007a9f733.camel@esd.eu>
Date: Wed, 24 Sep 2025 13:26:39 +0000
From: Stefan Mätje <stefan.maetje@....eu>
To: "mkl@...gutronix.de" <mkl@...gutronix.de>, "kuba@...nel.org"
	<kuba@...nel.org>
CC: "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net 09/10] can: esd_usb: Fix handling of TX context
 objects

Am Montag, dem 22.09.2025 um 17:17 -0700 schrieb Jakub Kicinski:
> On Mon, 22 Sep 2025 12:07:39 +0200 Marc Kleine-Budde wrote:
> > -		netdev_warn(netdev, "couldn't find free context\n");
> > +		netdev_warn(netdev, "No free context. Jobs: %d\n",
> > +			    atomic_read(&priv->active_tx_jobs));
> 
> This should really be rate limited or _once while we touch it.
> 

Changing this to a rate limited version would be fine with me. 

@Marc:
How to proceed further? Should I send a V3 of the original patch
set or should I split the patch set in two patch sets like you did?

The code would look then like:

	if (!context) {
		if (net_ratelimit())
			netdev_warn(netdev, "No free context. Jobs: %d\n",
				    atomic_read(&priv->active_tx_jobs));
		netif_stop_queue(netdev);
		ret = NETDEV_TX_BUSY;
		goto releasebuf;
	}

Best regards,
    Stefan