netdev - Re: [PATCH v2 net-next] net/hsr: add protocol version to fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250923170604.6c629d90@kernel.org>
Date: Tue, 23 Sep 2025 17:06:04 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jan Vaclav <jvaclav@...hat.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net/hsr: add protocol version to fill_info
 output

On Mon, 22 Sep 2025 11:37:45 +0200 Jan Vaclav wrote:
>  	if (hsr->prot_version == PRP_V1)
>  		proto = HSR_PROTOCOL_PRP;
> +	if (nla_put_u8(skb, IFLA_HSR_VERSION, hsr->prot_version))
> +		goto nla_put_failure;

Looks like configuration path does not allow setting version if proto
is PRP. Should we add an else before the if? since previous if is
checking for PRP already