netdev - Re: [PATCH net-next] eth: fbnic: Add support to read lane count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925101642.GD836419@horms.kernel.org>
Date: Thu, 25 Sep 2025 11:16:42 +0100
From: Simon Horman <horms@...nel.org>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kernel-team@...a.com,
	kuba@...nel.org, pabeni@...hat.com, vadim.fedorenko@...ux.dev
Subject: Re: [PATCH net-next] eth: fbnic: Add support to read lane count

On Wed, Sep 24, 2025 at 11:44:45AM -0700, Mohsin Bashir wrote:
> We are reporting the lane count in the link settings but the flag is not
> set to indicate that the driver supports lanes. Set the flag to report
> lane count.
> 
>  ~]# ethtool eth0 | grep Lanes
> 	Lanes: 2
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

It's not not entirely clear to me why Jakub's tag is here.

> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>

I agree this i correct because linkmodes_prepare_data()
will zero the lanes value, after retrieving it from the driver,
unless cap_link_lanes_supported is set.

Reviewed-by: Simon Horman <horms@...nel.org>

...