netdev - Re: [PATCH net-next v3 01/11] virtio-pci: Expose generic device capability operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925062741-mutt-send-email-mst@kernel.org>
Date: Thu, 25 Sep 2025 06:35:42 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Parav Pandit <parav@...dia.com>
Cc: Dan Jurgens <danielj@...dia.com>, Jason Wang <jasowang@...hat.com>,
	netdev@...r.kernel.org, alex.williamson@...hat.com,
	pabeni@...hat.com, virtualization@...ts.linux.dev,
	shshitrit@...dia.com, yohadt@...dia.com, xuanzhuo@...ux.alibaba.com,
	eperezma@...hat.com, shameerali.kolothum.thodi@...wei.com,
	jgg@...pe.ca, kevin.tian@...el.com, kuba@...nel.org,
	andrew+netdev@...n.ch, edumazet@...gle.com,
	Yishai Hadas <yishaih@...dia.com>
Subject: Re: [PATCH net-next v3 01/11] virtio-pci: Expose generic device
 capability operations

On Thu, Sep 25, 2025 at 03:21:38PM +0530, Parav Pandit wrote:
> Function pointers are there for multiple transports to implement their own
> implementation.

My understanding is that you want to use flow control admin commands 
in virtio net, without making it depend on virtio pci.
This why the callbacks are here. Is that right?

That is fair enough, but it looks like every new command then
needs a lot of boilerplate code with a callback a wrapper and
a transport implementation.

Why not just put all this code in virtio core? It looks like the
transport just needs to expose an API to find the admin vq.

-- 
MST