netdev - Re: [PATCH v2 bpf-next 1/3] xsk: avoid overwriting skb fields for multi-buffer traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoCnaL_PBDqWrQzMbUXHfXk_DAYvZ46Zn2X9Pot8iShrOw@mail.gmail.com>
Date: Fri, 26 Sep 2025 07:45:50 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, 
	andrii@...nel.org, netdev@...r.kernel.org, magnus.karlsson@...el.com, 
	stfomichev@...il.com
Subject: Re: [PATCH v2 bpf-next 1/3] xsk: avoid overwriting skb fields for
 multi-buffer traffic

On Fri, Sep 26, 2025 at 12:00 AM Maciej Fijalkowski
<maciej.fijalkowski@...el.com> wrote:
>
> We are unnecessarily setting a bunch of skb fields per each processed
> descriptor, which is redundant for fragmented frames.
>
> Let us set these respective members for first fragment only. To address
> both paths that we have within xsk_build_skb(), move assignments onto
> xsk_set_destructor_arg() and rename it to xsk_skb_init_misc().
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Thanks,
Jason