netdev - Re: [PATCH] net: qed: Remove redundant NULL checks after list_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175893060627.97160.14363249061224646644.git-patchwork-notify@kernel.org>
Date: Fri, 26 Sep 2025 23:50:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Zhen Ni <zhen.ni@...ystack.cn>
Cc: manishc@...vell.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH] net: qed: Remove redundant NULL checks after
 list_first_entry()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 24 Sep 2025 11:02:19 +0800 you wrote:
> list_first_entry() never returns NULL — if the list is empty, it still
> returns a pointer to an invalid object, leading to potential invalid
> memory access when dereferenced.
> The calls to list_first_entry() are always guarded by !list_empty(),
> which guarantees a valid entry is returned. Therefore, the additional
> `if (!p_buffer) break;` checks in qed_ooo_release_connection_isles(),
> qed_ooo_release_all_isles(), and qed_ooo_free() are redundant and
> unreachable.
> 
> [...]

Here is the summary with links:
  - net: qed: Remove redundant NULL checks after list_first_entry()
    https://git.kernel.org/netdev/net-next/c/fbb8bc408027

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html