netdev - Re: [PATCH net-next] net: phy: micrel: Fix lan8814_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNZl1NxC3OAUPS7A@horms.kernel.org>
Date: Fri, 26 Sep 2025 11:07:16 +0100
From: Simon Horman <horms@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, rmk+kernel@...linux.org.uk,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: micrel: Fix lan8814_config_init

On Thu, Sep 25, 2025 at 08:47:02AM +0200, Horatiu Vultur wrote:
> The blamed commit introduced the function lanphy_modify_page_reg which
> as name suggests it, it modifies the registers. In the same commit we
> have started to use this function inside the drivers. The problem is
> that in the function lan8814_config_init we passed the wrong page number
> when disabling the aneg towards host side. We passed extended page number
> 4(LAN8814_PAGE_COMMON_REGS) instead of extended page
> 5(LAN8814_PAGE_PORT_REGS)
> 
> Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> 
> ---
> this is targeting net-next and not net because the blamed commit doesn't
> exist on net

Thanks, I agree that the page was changed in the cited commit.
And it seems to me that it wasn't an intentional change.

Reviewed-by: Simon Horman <horms@...nel.org>