netdev - Re: [PATCH net-next v5 0/4] net: wangxun: support to configure RSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250925190401.70c85ada@kernel.org>
Date: Thu, 25 Sep 2025 19:04:01 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: <netdev@...r.kernel.org>, "'Andrew Lunn'" <andrew+netdev@...n.ch>,
 "'David S. Miller'" <davem@...emloft.net>, "'Eric Dumazet'"
 <edumazet@...gle.com>, "'Paolo Abeni'" <pabeni@...hat.com>, "'Simon
 Horman'" <horms@...nel.org>, "'Alexander Lobakin'"
 <aleksander.lobakin@...el.com>, "'Mengyuan Lou'"
 <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v5 0/4] net: wangxun: support to configure RSS

On Thu, 25 Sep 2025 15:28:11 +0800 Jiawen Wu wrote:
> On Thu, Sep 25, 2025 9:37 AM, Jakub Kicinski wrote:
> > On Mon, 22 Sep 2025 17:43:23 +0800 Jiawen Wu wrote:  
> > > Implement ethtool ops for RSS configuration, and support multiple RSS
> > > for multiple pools.  
> > 
> > There is a few tests for the RSS API in the tree:
> > 
> > tools/testing/selftests/drivers/net/hw/rss_api.py
> > tools/testing/selftests/drivers/net/hw/rss_ctx.py
> > 
> > Please run these and add the output to the cover letter.
> > 
> > Instructions for running the tests are here:
> > 
> > https://github.com/linux-netdev/nipa/wiki/Running-driver-tests  
> 
> The output shows many fail cases. Is it normal? Or is there some issue
> with my environment?

It's most;u normal, the test don't check capabilities so if you don't
support a feature the test case will fail.

> root@...S-7E16:~/net-next# NETIF=enp17s0f0 tools/testing/selftests/drivers/net/hw/rss_api.py
> TAP version 13
> 1..12
> ok 1 rss_api.test_rxfh_nl_set_fail
> ok 2 rss_api.test_rxfh_nl_set_indir
> not ok 3 rss_api.test_rxfh_nl_set_indir_ctx
> ok 4 rss_api.test_rxfh_indir_ntf
> not ok 5 rss_api.test_rxfh_indir_ctx_ntf
> ok 6 rss_api.test_rxfh_nl_set_key
> ok 7 rss_api.test_rxfh_fields
> not ok 9 rss_api.test_rxfh_fields_set_xfrm
> ok 10 rss_api.test_rxfh_fields_ntf
> not ok 11 rss_api.test_rss_ctx_add
> not ok 12 rss_api.test_rss_ctx_ntf
> # Totals: pass:6 fail:6 xfail:0 xpass:0 skip:0 error:0

These all look fine. You don't support RSS contexts (yet) so the
context tests can fail

> root@...S-7E16:~/net-next# NETIF=enp17s0f0 LOCAL_V4="10.10.10.1" REMOTE_V4="10.10.10.2" REMOTE_TYPE=ssh
> REMOTE_ARGS="root@....168.14.104" tools/testing/selftests/drivers/net/hw/rss_ctx.py
> root@....168.14.104's password:
> TAP version 13
> 1..17
> not ok 1 rss_ctx.test_rss_key_indir
> ok 2 rss_ctx.test_rss_queue_reconfigure # SKIP Not enough queues for the test or qstat not supported
> ok 3 rss_ctx.test_rss_resize
> ok 4 rss_ctx.test_hitless_key_update # SKIP Test requires command: iperf3

Please install iperf3 and retry just this one?

> not ok 5 rss_ctx.test_rss_context