netdev - Re: [PATCH iproute2-next] lib/bpf_legacy: Use userspace SHA-1 code instead of AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250927183641.GA1719@quark>
Date: Sat, 27 Sep 2025 11:36:41 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>
Cc: bpf@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH iproute2-next] lib/bpf_legacy: Use userspace SHA-1 code
 instead of AF_ALG

On Thu, Sep 25, 2025 at 03:53:22PM -0700, Eric Biggers wrote:
>  	ctx->obj_fd = open(pathname, O_RDONLY);
> -	if (ctx->obj_fd < 0)
> +	if (ctx->obj_fd < 0) {
> +		fprintf(stderr, "Error opening object %s: %s\n", pathname,
> +			strerror(errno));
>  		return ctx->obj_fd;
> +	}
> +
> +	ret = bpf_obj_hash(ctx->obj_fd, pathname, tmp);
> +	if (ret)
> +		return ret;

Correction: the 'return ret;' above should be 'goto out_fd;'.
I'll fix this in v2, but I'll wait a bit for more feedback first.

- Eric