netdev - Re: [PATCH net-next v4 0/5] bnxt_fwctl: fwctl for Broadcom Netxtreme devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALs4sv0T=AL354Mj2UCQGwaqWAznjDoaPQX=7zLsXz9=WxAiGQ@mail.gmail.com>
Date: Sun, 28 Sep 2025 12:05:36 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: jgg@...pe.ca, michael.chan@...adcom.com
Cc: dave.jiang@...el.com, saeedm@...dia.com, Jonathan.Cameron@...wei.com, 
	davem@...emloft.net, corbet@....net, edumazet@...gle.com, gospo@...adcom.com, 
	kuba@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com, 
	andrew+netdev@...n.ch, selvin.xavier@...adcom.com, leon@...nel.org, 
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v4 0/5] bnxt_fwctl: fwctl for Broadcom Netxtreme devices

On Sat, Sep 27, 2025 at 3:02 PM Pavan Chebbi <pavan.chebbi@...adcom.com> wrote:
>
> Introducing bnxt_fwctl which follows along Jason's work [1].
> It is an aux bus driver that enables fwctl for Broadcom
> NetXtreme 574xx, 575xx and 576xx series chipsets by using
> bnxt driver's capability to talk to devices' firmware.
>
> The first patch moves the ULP definitions to a common place
> inside include/linux/bnxt/. The second and third patches
> refactor and extend the existing bnxt aux bus functions to
> be able to add more than one auxiliary device. The last three
> patches create an additional bnxt aux device, add bnxt_fwctl,
> and the documentation.
>
> [1] https://lore.kernel.org/netdev/0-v5-642aa0c94070+4447f-fwctl_jgg@nvidia.com/
>
> v4: In patch #4, added the missing kfree on error for response
> buffer. Improved documentation in patch #5 based on comments
> from Dave.
>

Dear maintainers, my not-yet-reviewed v4 series is moved to 'Changes Requested'.
I am not sure if I missed anything. Can you pls help me know!

> v3: Addressed the review comments as below
> Patch #1: Removed redundant common.h [thanks Saeed]
> Patch #2 and #3 merged into a single patch [thanks Jonathan]
> Patch #3: Addressed comments from Jonathan
> Patch #4 and #5: Addressed comments from Jonathan and Dave
>
> v2: In patch #5, fixed a sparse warning where a __le16 was
> degraded to an integer. Also addressed kdoc warnings for
> include/uapi/fwctl/bnxt.h in the same patch.
>
> v1: https://lore.kernel.org/netdev/20250922090851.719913-1-pavan.chebbi@broadcom.com/
>
> The following are changes since commit fec734e8d564d55fb6bd4909ae2e68814d21d0a1:
>   Merge tag 'riscv-for-linus-v6.17-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
> and are available in the git repository at:
>   https://github.com/pavanchebbi/linux/tree/bnxt_fwctl_v4

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5469 bytes)