netdev - Re: [PATCH net-next 3/3] net: add NUMA awareness to skb_attempt_defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJ9=dv2=itEKAyhBVY6edkYRLCuGLbgt_vMNpohNU00rQ@mail.gmail.com>
Date: Sun, 28 Sep 2025 01:45:00 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/3] net: add NUMA awareness to skb_attempt_defer_free()

On Sat, Sep 27, 2025 at 1:28 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:
>
> On Fri, Sep 26, 2025 at 8:13 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > Instead of sharing sd->defer_list & sd->defer_count with
> > many cpus, add one pair for each NUMA node.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>

> > -static void skb_defer_free_flush(struct softnet_data *sd)
> > +struct skb_defer_node __percpu *skb_defer_nodes;
>
> seems this is unused, given it's close to the end of cycle
> maybe this can be fixed up while applying ? :)

Good catch, I moved it to net_hotdata but forgot to remove this leftover.

Will send a V2.

Thanks.