netdev - Re: [PATCH v2 net-next 03/13] selftest: packetdrill: Define common TCP Fast Open cookie.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAVpQUBfKYBagmPS1VSygq6FWWRPpPSBG1ozBa37xYO8RXnTdQ@mail.gmail.com>
Date: Sun, 28 Sep 2025 12:12:31 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 03/13] selftest: packetdrill: Define common
 TCP Fast Open cookie.

On Sun, Sep 28, 2025 at 11:10 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Kuniyuki Iwashima wrote:
> > TCP Fast Open cookie is generated in __tcp_fastopen_cookie_gen_cipher().
> >
> > The cookie value is generated from src/dst IPs and a key configured by
> > setsockopt(TCP_FASTOPEN_KEY) or net.ipv4.tcp_fastopen_key.
> >
> > The default.sh sets net.ipv4.tcp_fastopen_key, and the original packetdrill
> > defines the corresponding cookie as TFO_COOKIE in run_all.py. [0]
>
> tiny, not reason for respin: no link [0].

Oops, the link was

Link: https://github.com/google/packetdrill/blob/7230b3990f94/gtests/net/packetdrill/run_all.py#L65
#[0]

Thanks!

>
> > Then, each test does not need to care about the value, and we can easily
> > update TFO_COOKIE in case __tcp_fastopen_cookie_gen_cipher() changes the
> > algorithm.
> >
> > However, some tests use the bare hex value for specific IPv4 addresses
> > and do not support IPv6.
> >
> > Let's define the same TFO_COOKIE in ksft_runner.sh.
> >
> > We will replace such bare hex values with TFO_COOKIE except for a single
> > test for setsockopt(TCP_FASTOPEN_KEY).
> >
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>