netdev - Re: [PATCH 2/2] net: usb: support quirks in usbnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250928212351.3b5828c2@kernel.org>
Date: Sun, 28 Sep 2025 21:23:51 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: yicongsrfy@....com
Cc: oliver@...kum.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, marcan@...can.st, pabeni@...hat.com,
 linux-usb@...r.kernel.org, netdev@...r.kernel.org, yicong@...inos.cn
Subject: Re: [PATCH 2/2] net: usb: support quirks in usbnet

On Sun, 28 Sep 2025 09:46:31 +0800 yicongsrfy@....com wrote:
> +	const struct usb_device_id *match = usb_match_id(intf,
> +							 usbnet_ignore_list);
> +
> +	return match == NULL ? false : true;

coccicheck says:

drivers/net/usb/usbnet_quirks.h:40:24-29: WARNING: conversion to bool not needed here

this function could be simply:

{
	return !usb_match_id(intf, usbnet_ignore_list);
}