netdev - Re: [PATCH net-next] Revert "net: group sk_backlog and sk_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aNqXETgt9pHIsnvx@horms.kernel.org>
Date: Mon, 29 Sep 2025 15:26:25 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, kernel test robot <oliver.sang@...el.com>,
	David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH net-next] Revert "net: group sk_backlog and
 sk_receive_queue"

On Mon, Sep 29, 2025 at 02:08:39PM +0000, Eric Dumazet wrote:
> This reverts commit 4effb335b5dab08cb6e2c38d038910f8b527cfc9.
> 
> This was a benefit for UDP flood case, which was later greatly improved
> with commits 6471658dc66c ("udp: use skb_attempt_defer_free()")
> and b650bf0977d3 ("udp: remove busylock and add per NUMA queues").
> 
> Apparently blamed commit added a regression for RAW sockets, possibly
> because they do not use the dual RX queue strategy that UDP has.
> 
> sock_queue_rcv_skb_reason() and RAW recvmsg() compete for sk_receive_buf
> and sk_rmem_alloc changes, and them being in the same
> cache line reduce performance.
> 
> Fixes: 4effb335b5da ("net: group sk_backlog and sk_receive_queue")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202509281326.f605b4eb-lkp@intel.com
> Cc: Willem de Bruijn <willemb@...gle.com>
> Cc: David Ahern <dsahern@...nel.org>
> Cc: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---
>  include/net/sock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry Eric, but it looks like you forgot your SoB.

...