netdev - Re: Error during building on next-20250926

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f3a1bad-4e8e-473f-8f78-92a6b96450b9@linuxfoundation.org>
Date: Mon, 29 Sep 2025 10:05:38 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: "Berg, Johannes" <johannes.berg@...el.com>,
 Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 David Gow <davidgow@...gle.com>,
 "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
Cc: shuah <shuah@...nel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
 KUnit Development <kunit-dev@...glegroups.com>,
 Networking <netdev@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: Error during building on next-20250926 - kunit.py run --alltests
 run

On 9/29/25 01:07, Berg, Johannes wrote:
> +Miri
> 
> Hi Shuah,
> 
>>> I am seeing the following error during "kunit.py run --alltests run"
>>> next-20250926.
>>>
>>> $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit
>>> --jobs=16
>>> ERROR:root:/usr/bin/ld: drivers/net/wireless/intel/iwlwifi/tests/devinfo.o: in
>> function `devinfo_pci_ids_config':
>>> devinfo.c:(.text+0x2d): undefined reference to `iwl_bz_mac_cfg'
>>> collect2: error: ld returned 1 exit status
>>> make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped]
>>> Error 1
>>> make[2]: *** [/linux/linux_next/Makefile:1242: vmlinux] Error 2
>>> make[1]: *** [/linux/linux_next/Makefile:248: __sub-make] Error 2
>>> make: *** [Makefile:248: __sub-make] Error 2
> 
> Yeah, really my mistake, I didn't consider what happens in the test there when iwlwifi is built but without CONFIG_IWLMVM and CONFIG_IWLMLD.
> 
> I think we should add those to actually run their kunit tests too, which would fix the build issue, and maybe even CONFIG_IWLDVM to increase coverage of the tests in iwlwifi itself. I can send a patch for that.
> 
> All that said, the patch that breaks it is in linux-next via iwlwifi-next but seems to actually have missed the cutoff for 6.18, so we're good for now and I suppose Miri can even squash the build fix into that later.
> 

Thank you. Sounds like a plan.

I will send my kunit pr to Linus then.

thanks,
-- Shuah