netdev - Re: [Intel-wired-lan] [PATCH net] idpf: fix mismatched free function for dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dda14ca-7e58-448e-8b05-e5f6293911f0@intel.com>
Date: Mon, 29 Sep 2025 15:53:40 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, <krishneil.k.singh@...el.com>,
	<alan.brady@...el.com>, <aleksander.lobakin@...el.com>,
	<andrew+netdev@...n.ch>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <horms@...nel.org>,
	<netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>, "Tantilov, Emil
 S" <emil.s.tantilov@...el.com>, Joshua Hay <joshua.a.hay@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH net] idpf: fix mismatched free function
 for dma_alloc_coherent



On 9/25/2025 11:02 AM, Alok Tiwari wrote:
> The mailbox receive path allocates coherent DMA memory with
> dma_alloc_coherent(), but frees it with dmam_free_coherent().
> This is incorrect since dmam_free_coherent() is only valid for
> buffers allocated with dmam_alloc_coherent().
> 
> Fix the mismatch by using dma_free_coherent() instead of
> dmam_free_coherent
> 
> Fixes: e54232da1238 ("idpf: refactor idpf_recv_mb_msg")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---

This is tagged for net, not iwl-net. The fix seems obvious to me, and
unlikely to be covered well by validation tests, due to being an error
cleanup flow.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

I don't have an issue with this being taken directly to net, but would
appreciate an ACK by someone from the idpf driver team first to make
sure we're in agreement. Alternatively, if anyone has objection and
would prefer I pick this up for IWL net dev-queue, please let me know.


>  drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index 6330d4a0ae07..c1f34381333d 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> @@ -702,9 +702,9 @@ int idpf_recv_mb_msg(struct idpf_adapter *adapter)
>  		/* If post failed clear the only buffer we supplied */
>  		if (post_err) {
>  			if (dma_mem)
> -				dmam_free_coherent(&adapter->pdev->dev,
> -						   dma_mem->size, dma_mem->va,
> -						   dma_mem->pa);
> +				dma_free_coherent(&adapter->pdev->dev,
> +						  dma_mem->size, dma_mem->va,
> +						  dma_mem->pa);
>  			break;
>  		}
>  



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)