netdev - Re: [PATCH net-next 14/20] netkit: Add single device mode for netkit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5950fc56-bfbb-4dc0-9f9e-e84117b0b550@iogearbox.net>
Date: Mon, 29 Sep 2025 09:55:27 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Jordan Rife <jordan@...fe.io>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, kuba@...nel.org,
 davem@...emloft.net, razor@...ckwall.org, pabeni@...hat.com,
 willemb@...gle.com, sdf@...ichev.me, john.fastabend@...il.com,
 martin.lau@...nel.org, maciej.fijalkowski@...el.com,
 magnus.karlsson@...el.com, David Wei <dw@...idwei.uk>
Subject: Re: [PATCH net-next 14/20] netkit: Add single device mode for netkit

On 9/27/25 3:10 AM, Jordan Rife wrote:
> On Fri, Sep 19, 2025 at 11:31:47PM +0200, Daniel Borkmann wrote:
[...]
> 
> This seems very cool. I'm curious, in single device mode, how would
> traffic originating in the host ns make its way into a pod hosting a
> QEMU VM using an AF_XDP backend? How would redirection work between two
> such VMs on the same host?

For this case the plan would be to have the regular netkit pair connecting
host to Pod through skbs and then we'd direct traffic to that queue bound
netkit device which injects it into the af_xdp socket in ndo_start_xmit.

[...]
>> +	if (pair != NETKIT_DEVICE_PAIR &&
> 
> nit: IMO this would be a little clearer without the inverted logic:

Ack, will fix.

[...]
> 
> Reviewed-by: Jordan Rife <jordan@...fe.io>

Thanks!