netdev - Re: [PATCH v18 01/20] cxl: Add type2 device basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee5d4ff7-da7b-4caa-b723-b4b5a09bfc39@amd.com>
Date: Mon, 29 Sep 2025 11:21:33 +0100
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>,
 alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
 dan.j.williams@...el.com, edward.cree@....com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 dave.jiang@...el.com, Alison Schofield <alison.schofield@...el.com>
Subject: Re: [PATCH v18 01/20] cxl: Add type2 device basic support


On 9/23/25 12:21, Alejandro Lucero Palau wrote:
>
> On 9/18/25 11:55, Jonathan Cameron wrote:
>> On Thu, 18 Sep 2025 10:17:27 +0100
>> alejandro.lucero-palau@....com wrote:
>>
>>> From: Alejandro Lucero <alucerop@....com>
>>>
>>> Differentiate CXL memory expanders (type 3) from CXL device 
>>> accelerators
>>> (type 2) with a new function for initializing cxl_dev_state and a macro
>>> for helping accel drivers to embed cxl_dev_state inside a private
>>> struct.
>>>
>>> Move structs to include/cxl as the size of the accel driver private
>>> struct embedding cxl_dev_state needs to know the size of this struct.
>>>
>>> Use same new initialization with the type3 pci driver.
>>>
>>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>>> Reviewed-by: Alison Schofield <alison.schofield@...el.com>
>>
>>> diff --git a/Documentation/driver-api/cxl/theory-of-operation.rst 
>>> b/Documentation/driver-api/cxl/theory-of-operation.rst
>>> index 257f513e320c..ab8ebe7722a9 100644
>>> --- a/Documentation/driver-api/cxl/theory-of-operation.rst
>>> +++ b/Documentation/driver-api/cxl/theory-of-operation.rst
>>> @@ -347,6 +347,9 @@ CXL Core
>>>   .. kernel-doc:: drivers/cxl/cxl.h
>>>      :internal:
>>>   +.. kernel-doc:: include/cxl/cxl.h
>>> +   :internal:
>>> +
>> Smells like a merge conflict issue given same entry is already there.
>>
>
> Yes, I'll fix it.
>
>
> Thanks
>

Hi Jonathan,


When double-checking for v19, I am not sure what you meant here. It 
seems my answer was in "automatic mode" since there is no duplicate 
entry at all.


Note there is one line for another file with same name but different 
path. We discussed the file name for public cxl API for type2 drivers 
time ago, so I think this should not be a problem.



>
>>>   .. kernel-doc:: drivers/cxl/acpi.c
>>>      :identifiers: add_cxl_resources
>>