netdev - Re: [PATCH] usbnet: Fix using smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98852ec27b03a4b7a16243e32b616a0189e32165@linux.dev>
Date: Wed, 01 Oct 2025 00:39:18 +0000
From: "Zqiang" <qiang.zhang@...ux.dev>
To: "Jakub Kicinski" <kuba@...nel.org>
Cc: horms@...nel.org, davem@...emloft.net, pabeni@...hat.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: Fix using smp_processor_id() in preemptible code
 warnings

> 
> On Tue, 30 Sep 2025 16:46:36 +0800 Zqiang wrote:
> 
> > 
> > The usbnet_skb_return() can be invoked in preemptible task-context,
> >  this commit therefore use get_cpu_ptr/put_cpu_ptr() instead of
> >  this_cpu_ptr() to get stats64 pointer.
> > 
> We also call netif_rx() which historically wanted to be in bh context.
> I think that disabling bh in usbnet_resume_rx() may be a better idea.


Actually, the netif_rx() will disable bh internally when call from
process context.
but the skb_defer_rx_timestamp() is usually called in the bh or
interrupt context.

Anyway, I will disable bh in usbnet_resume_rx() and resend.


Thanks
Zqiang


> -- 
> pw-bot: cr
>