Message-ID: <63034035-03e4-4184-afce-7e1a897a90e9@efficios.com>
Date: Thu, 2 Oct 2025 09:53:24 -0400
From: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To: Greg KH <gregkh@...uxfoundation.org>, Byungchul Park <byungchul@...com>
Cc: linux-kernel@...r.kernel.org, kernel_team@...ynix.com,
 torvalds@...ux-foundation.org, damien.lemoal@...nsource.wdc.com,
 linux-ide@...r.kernel.org, adilger.kernel@...ger.ca,
 linux-ext4@...r.kernel.org, mingo@...hat.com, peterz@...radead.org,
 will@...nel.org, tglx@...utronix.de, rostedt@...dmis.org,
 joel@...lfernandes.org, sashal@...nel.org, daniel.vetter@...ll.ch,
 duyuyang@...il.com, johannes.berg@...el.com, tj@...nel.org, tytso@....edu,
 willy@...radead.org, david@...morbit.com, amir73il@...il.com,
 kernel-team@....com, linux-mm@...ck.org, akpm@...ux-foundation.org,
 mhocko@...nel.org, minchan@...nel.org, hannes@...xchg.org,
 vdavydov.dev@...il.com, sj@...nel.org, jglisse@...hat.com,
 dennis@...nel.org, cl@...ux.com, penberg@...nel.org, rientjes@...gle.com,
 vbabka@...e.cz, ngupta@...are.org, linux-block@...r.kernel.org,
 josef@...icpanda.com, linux-fsdevel@...r.kernel.org, jack@...e.cz,
 jlayton@...nel.org, dan.j.williams@...el.com, hch@...radead.org,
 djwong@...nel.org, dri-devel@...ts.freedesktop.org,
 rodrigosiqueiramelo@...il.com, melissa.srw@...il.com,
 hamohammed.sa@...il.com, harry.yoo@...cle.com, chris.p.wilson@...el.com,
 gwan-gyeong.mun@...el.com, max.byungchul.park@...il.com,
 boqun.feng@...il.com, longman@...hat.com, yunseong.kim@...csson.com,
 ysk@...lloc.com, yeoreum.yun@....com, netdev@...r.kernel.org,
 matthew.brost@...el.com, her0gyugyu@...il.com, corbet@....net,
 catalin.marinas@....com, bp@...en8.de, dave.hansen@...ux.intel.com,
 x86@...nel.org, hpa@...or.com, luto@...nel.org, sumit.semwal@...aro.org,
 gustavo@...ovan.org, christian.koenig@....com, andi.shyti@...nel.org,
 arnd@...db.de, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
 rppt@...nel.org, surenb@...gle.com, mcgrof@...nel.org, petr.pavlu@...e.com,
 da.gomez@...nel.org, samitolvanen@...gle.com, paulmck@...nel.org,
 frederic@...nel.org, neeraj.upadhyay@...nel.org, joelagnelf@...dia.com,
 josh@...htriplett.org, urezki@...il.com, jiangshanlai@...il.com,
 qiang.zhang@...ux.dev, juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com, bsegall@...gle.com, mgorman@...e.de,
 vschneid@...hat.com, chuck.lever@...cle.com, neil@...wn.name,
 okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com, trondmy@...nel.org,
 anna@...nel.org, kees@...nel.org, bigeasy@...utronix.de,
 clrkwllms@...nel.org, mark.rutland@....com, ada.coupriediaz@....com,
 kristina.martsenko@....com, wangkefeng.wang@...wei.com, broonie@...nel.org,
 kevin.brodsky@....com, dwmw@...zon.co.uk, shakeel.butt@...ux.dev,
 ast@...nel.org, ziy@...dia.com, yuzhao@...gle.com,
 baolin.wang@...ux.alibaba.com, usamaarif642@...il.com,
 joel.granados@...nel.org, richard.weiyang@...il.com,
 geert+renesas@...der.be, tim.c.chen@...ux.intel.com, linux@...blig.org,
 alexander.shishkin@...ux.intel.com, lillian@...r-ark.net,
 chenhuacai@...nel.org, francesco@...la.it, guoweikang.kernel@...il.com,
 link@...o.com, jpoimboe@...nel.org, masahiroy@...nel.org,
 brauner@...nel.org, thomas.weissschuh@...utronix.de, oleg@...hat.com,
 mjguzik@...il.com, andrii@...nel.org, wangfushuai@...du.com,
 linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org,
 linux-i2c@...r.kernel.org, linux-arch@...r.kernel.org,
 linux-modules@...r.kernel.org, rcu@...r.kernel.org,
 linux-nfs@...r.kernel.org, linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH v17 01/47] llist: move llist_{head,node} definition to
 types.h

On 2025-10-02 04:24, Greg KH wrote:
> On Thu, Oct 02, 2025 at 05:12:01PM +0900, Byungchul Park wrote:
>> llist_head and llist_node can be used by some other header files.  For
>> example, dept for tracking dependencies uses llist in its header.  To
>> avoid header dependency, move them to types.h.
> 
> If you need llist in your code, then include llist.h.  Don't force all
> types.h users to do so as there is not a dependency in types.h for
> llist.h.
> 
> This patch shouldn't be needed as you are hiding "header dependency" for
> other files.

I agree that moving this into a catch-all types.h is not what we should
aim for.

However, it's a good practice to move the type declarations to a
separate header file, so code that only cares about type and not
implementation of static inline functions can include just that.

Perhaps we can move struct llist_head and struct llist_node to a new
include/linux/llist_types.h instead ?

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

Powered by blists - more mailing lists