netdev - Re: [PATCH net] selftests: net: unify the Makefile formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251002085807.370bee93@kernel.org>
Date: Thu, 2 Oct 2025 08:58:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org,
 jv@...sburgh.net, olteanv@...il.com, jiri@...nulli.us, mst@...hat.com,
 jasowang@...hat.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 kuniyu@...gle.com, martineau@...nel.org, pablo@...filter.org,
 kadlec@...filter.org, fw@...len.de, antonio@...nvpn.net,
 allison.henderson@...cle.com, petrm@...dia.com, razor@...ckwall.org,
 idosch@...dia.com, linux-kselftest@...r.kernel.org, mptcp@...ts.linux.dev,
 netfilter-devel@...r.kernel.org, coreteam@...filter.org,
 davem@...emloft.net
Subject: Re: [PATCH net] selftests: net: unify the Makefile formats

On Thu, 2 Oct 2025 12:48:59 +0200 Matthieu Baerts wrote:
> Strange, I think all other blocks are OK in this patch, except this one:
> the order is the same as before (so not sorted by alphabetical order),
> and the last line is not "# end of TEST_PROGS" as expected.

Well spotted! I typed the comments manually.

The checker was just checking if there's a comment at the end, let me
make it also check that the variable name is correct if the comment
is not empty.