netdev - Re: [PATCH net-next] net: psp: don't assume reply skbs will have a socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVpQUCZNhW7zvFrL-kmfkks=u0RtOBW+a-R3BxtqHjt0aud7w@mail.gmail.com>
Date: Wed, 1 Oct 2025 23:28:15 -0700
From: Kuniyuki Iwashima <kuniyu@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, 
	ncardwell@...gle.com, daniel.zahka@...il.com, willemb@...gle.com
Subject: Re: [PATCH net-next] net: psp: don't assume reply skbs will have a socket

On Tue, Sep 30, 2025 at 7:24 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Rx path may be passing around unreferenced sockets, which means
> that skb_set_owner_edemux() may not set skb->sk and PSP will crash:
>
>   KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017]
>   RIP: 0010:psp_reply_set_decrypted (./include/net/psp/functions.h:132 net/psp/psp_sock.c:287)
>     tcp_v6_send_response.constprop.0 (net/ipv6/tcp_ipv6.c:979)
>     tcp_v6_send_reset (net/ipv6/tcp_ipv6.c:1140 (discriminator 1))
>     tcp_v6_do_rcv (net/ipv6/tcp_ipv6.c:1683)
>     tcp_v6_rcv (net/ipv6/tcp_ipv6.c:1912)
>
> Fixes: 659a2899a57d ("tcp: add datapath logic for PSP with inline key exchange")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...gle.com>

Thanks!