[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20251002091224.11-1-alsp705@gmail.com>
Date: Thu, 2 Oct 2025 12:12:23 +0300
From: Alexandr Sapozhnkiov <alsp705@...il.com>
To: Pavan Chebbi <pavan.chebbi@...adcom.com>,
Michael Chan <mchan@...adcom.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: Alexandr Sapozhnikov <alsp705@...il.com>,
netdev@...r.kernel.org,
lvc-project@...uxtesting.org
Subject: [PATCH] fix uninit value using in tg3_setup_fiber_mii_phy()
From: Alexandr Sapozhnikov <alsp705@...il.com>
There is a way when we go to the goto fiber_setup_done label
and the condition current_link_up && current_duplex == DUPLEX_FULL
is met, then the tg3_setup_flow_control() function is executed with
undefined values of local_adv and remote_adv.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexandr Sapozhnikov <alsp705@...il.com>
---
drivers/net/ethernet/broadcom/tg3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 1589a49b876c..1fa61328c1b9 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -5802,7 +5802,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, bool force_reset)
u32 current_speed = SPEED_UNKNOWN;
u8 current_duplex = DUPLEX_UNKNOWN;
bool current_link_up = false;
- u32 local_adv, remote_adv, sgsr;
+ u32 local_adv = 0, remote_adv = 0, sgsr;
if ((tg3_asic_rev(tp) == ASIC_REV_5719 ||
tg3_asic_rev(tp) == ASIC_REV_5720) &&
--
2.43.0
Powered by blists - more mailing lists