netdev - Re: [PATCH] net: fsl_pq_mdio: Fix device node reference leak in fsl_pq_mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b109dcf89e3e1314224e5a29706154c2e612e079.camel@gmail.com>
Date: Fri, 03 Oct 2025 20:39:27 +0300
From: Erick Karanja <karanja99erick@...il.com>
To: Markus Elfring <Markus.Elfring@....de>, netdev@...r.kernel.org, 
	linux-kernel-mentees@...ts.linuxfoundation.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>,  David Hunter <david.hunter.linux@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Shuah Khan <skhan@...uxfoundation.org>, Simon Horman
 <horms@...nel.org>
Subject: Re: [PATCH] net: fsl_pq_mdio: Fix device node reference leak in
 fsl_pq_mdio_probe

On Fri, 2025-10-03 at 18:32 +0200, Markus Elfring wrote:
> > Add missing of_node_put call to release device node tbi obtained
> > via for_each_child_of_node.
> 
> Will it become helpful to append parentheses to function names?
Yes, it is necessary.
> 
> Regards,
> Markus