netdev - Re: [PATCH] doc/netlink: Expand nftables specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <JUuZco3v6YeIraurnU7qR-yqiNiPq8B5F6MJDG_2_tIrtMvkLEFhhPnns2BV7YCvAYkBLlhkadllZyRgQ7LmNWyWihwYr1dU9526sV63Ew4=@protonmail.com>
Date: Fri, 03 Oct 2025 17:51:54 +0000
From: "Remy D. Farley" <one-d-wide@...tonmail.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] doc/netlink: Expand nftables specification

On Thursday, October 2nd, 2025 at 10:11 PM, Jakub Kicinski <kuba@...nel.org> wrote:
> Could you try running
> 
> 	make -C tools/net/ynl/ -j
> 
> in the kernel tree?

Oops, will do :)

> Looks like there is an issue either with this patch or the ReST
> generator we have to render the docs. I get:
> 
>   WARNING:root:Failed to parse ../../../../Documentation/netlink/specs/nftables.yaml.
>   WARNING:root:'doc'

This one was because of a missing doc comment in "getcompat" operation (fixed in v2).

Also, it caught another issue. Python yaml doesn't distinguish an empty
attrset/list and a null-value:

```yaml
  dump: # attrset
    reply: # null (but attrset expected in code)
      # no attribute here => dump["reply"] is None
```

I think it's useful to have a machine readable mark to signal that the
operation supports dump flag, even though there're no attributes outlined yet.
I fixed it by simply checking for null in ynl_gen_rst.py .