netdev - [Query] octeon_ep: correct mailbox response type in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <306929b1-0119-4c5a-8284-b78d9025e37d@oracle.com>
Date: Fri, 3 Oct 2025 19:57:24 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: vburru@...vell.com, sedara@...vell.com,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, kuba@...nel.org,
        Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: [Query] octeon_ep: correct mailbox response type in get_mtu

Hi,

Since this function is octep_pfvf_get_mtu,
shouldn’t the response type be s_get_mtu rather than s_set_mtu?”

---

--- a/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
+++ b/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
@@ -146,7 +146,7 @@ static void octep_pfvf_get_mtu(struct octep_device 
*oct, u32 vf_id,
  {
         int max_rx_pktlen = oct->netdev->max_mtu + (ETH_HLEN + 
ETH_FCS_LEN);

-       rsp->s_set_mtu.type = OCTEP_PFVF_MBOX_TYPE_RSP_ACK;
+       rsp->s_get_mtu.type = OCTEP_PFVF_MBOX_TYPE_RSP_ACK; //propose change
         rsp->s_get_mtu.mtu = max_rx_pktlen;
  }


Thanks,
Alok