netdev - Re: [PATCH net v2] hdlc_ppp: fix potential null pointer in ppp_cp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251003091729.3158a8db@kernel.org>
Date: Fri, 3 Oct 2025 09:17:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kriish Sharma <kriish.sharma2006@...il.com>
Cc: khalasa@...p.pl, khc@...waw.pl, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] hdlc_ppp: fix potential null pointer in
 ppp_cp_event logging

On Fri,  3 Oct 2025 09:29:18 +0000 Kriish Sharma wrote:
> Fixes: 262858079afd ("Add linux-next specific files for 20250926")

This is not a fix, please post the next version in 2 weeks
(after the merge window has closed) and without the Fixes tag. 

The warning (not so?) obviously doesn't apply to the kernel. 
Kernel print methods will output "(null)" if you pass 0 as 
the value to %s.

I defer to Krzysztof on whether we should proceed with this
patch as a cleanup, but -Wformat-overflow= is disabled in 
the kernel builds for a good reason. This is not a fix.
-- 
pw-bot: cr