netdev - Re: [PATCH net 1/9] eth: fbnic: fix missing programming of the default descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251004164451.GF3060232@horms.kernel.org>
Date: Sat, 4 Oct 2025 17:44:51 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, bpf@...r.kernel.org,
	alexanderduyck@...com, jacob.e.keller@...el.com,
	mohsin.bashr@...il.com
Subject: Re: [PATCH net 1/9] eth: fbnic: fix missing programming of the
 default descriptor

On Fri, Oct 03, 2025 at 04:30:17PM -0700, Jakub Kicinski wrote:
> XDP_TX typically uses no offloads. To optimize XDP we added a "default
> descriptor" feature to the chip, which allows us to send XDP frames with
> just the buffer descriptors (DMA address + length). All the metadata
> descriptors are derived from the queue config.
> 
> Commit under Fixes missed adding setting the defaults up when transplanting
> the code from the prototype driver. Importantly after reset the "request
> completion" bit is not set. Packets still get sent but there's no
> completion, so ring is not cleaned up. We can send one ring's worth
> of packets and then will start dropping all frames that got the XDP_TX
> action from the XDP prog.
> 
> Fixes: 168deb7b31b2 ("eth: fbnic: Add support for XDP_TX action")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>