netdev - Re: [PATCH net 3/9] eth: fbnic: fix saving stats from XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251004164556.GH3060232@horms.kernel.org>
Date: Sat, 4 Oct 2025 17:45:56 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, bpf@...r.kernel.org,
	alexanderduyck@...com, sdf@...ichev.me, mohsin.bashr@...il.com
Subject: Re: [PATCH net 3/9] eth: fbnic: fix saving stats from XDP_TX rings
 on close

On Fri, Oct 03, 2025 at 04:30:19PM -0700, Jakub Kicinski wrote:
> When rings are freed - stats get added to the device level stat
> structs. Save the stats from the XDP_TX ring just as Tx stats.
> Previously they would be saved to Rx and Tx stats. So we'd not
> see XDP_TX packets as Rx during runtime but after an down/up cycle
> the packets would appear in stats.
> 
> Correct the helper used by ethtool code which does a runtime
> config switch.
> 
> Fixes: 5213ff086344 ("eth: fbnic: Collect packet statistics for XDP")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>