netdev - Re: [PATCH net 6/9] eth: fbnic: fix reporting of alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251004164813.GK3060232@horms.kernel.org>
Date: Sat, 4 Oct 2025 17:48:13 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, bpf@...r.kernel.org,
	alexanderduyck@...com, mohsin.bashr@...il.com,
	vadim.fedorenko@...ux.dev, jdamato@...tly.com,
	aleksander.lobakin@...el.com
Subject: Re: [PATCH net 6/9] eth: fbnic: fix reporting of alloc_failed qstats

On Fri, Oct 03, 2025 at 04:30:22PM -0700, Jakub Kicinski wrote:
> Rx processing under normal circumstances has 3 rings - 2 buffer
> rings (heads, payloads) and a completion ring. All the rings
> have a struct fbnic_ring. Make sure we expose alloc_failed
> counter from the buffer rings, previously only the alloc_failed
> from the completion ring was reported, even tho all ring types
> may increment this counter (buffer rings in __fbnic_fill_bdq()).
> 
> This makes the pp_alloc_fail.py test pass, it expects the qstat
> to be incrementing as page pool injections happen.
> 
> Fixes: 67dc4eb5fc92 ("eth: fbnic: report software Rx queue stats")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Simon Horman <horms@...nel.org>