netdev - RE: [Intel-wired-lan] [PATCH iwl-net v1 3/3] ixgbe: use EOPNOTSUPP instead of ENOTSUPP in ixgbe_ptp_feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA3PR11MB8986B636081D4C506C6B98D4E5E3A@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 6 Oct 2025 14:00:26 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Kohei Enju <enjuk@...zon.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Auke Kok
	<auke-jan.h.kok@...el.com>, Jeff Garzik <jgarzik@...hat.com>, Sasha Neftin
	<sasha.neftin@...el.com>, Richard Cochran <richardcochran@...il.com>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>, "kohei.enju@...il.com"
	<kohei.enju@...il.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net v1 3/3] ixgbe: use EOPNOTSUPP
 instead of ENOTSUPP in ixgbe_ptp_feature_enable()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Kohei Enju
> Sent: Monday, October 6, 2025 2:35 PM
> To: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>; Andrew Lunn
> <andrew+netdev@...n.ch>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Auke Kok <auke-jan.h.kok@...el.com>; Jeff
> Garzik <jgarzik@...hat.com>; Sasha Neftin <sasha.neftin@...el.com>;
> Richard Cochran <richardcochran@...il.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>; kohei.enju@...il.com; Kohei Enju
> <enjuk@...zon.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1 3/3] ixgbe: use
> EOPNOTSUPP instead of ENOTSUPP in ixgbe_ptp_feature_enable()
> 
> When the requested PTP feature is not supported,
> ixgbe_ptp_feature_enable() returns -ENOTSUPP, causing userland
> programs to get "Unknown error 524".
> 
> Since EOPNOTSUPP should be used when error is propagated to userland,
> return -EOPNOTSUPP instead of -ENOTSUPP.
> 
> Fixes: 3a6a4edaa592 ("ixgbe: Hardware Timestamping + PTP Hardware
> Clock (PHC)")
> Signed-off-by: Kohei Enju <enjuk@...zon.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> index 114dd88fc71c..6885d2343c48 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
> @@ -641,7 +641,7 @@ static int ixgbe_ptp_feature_enable(struct
> ptp_clock_info *ptp,
>  	 * disabled
>  	 */
>  	if (rq->type != PTP_CLK_REQ_PPS || !adapter->ptp_setup_sdp)
> -		return -ENOTSUPP;
> +		return -EOPNOTSUPP;
> 
>  	if (on)
>  		adapter->flags2 |= IXGBE_FLAG2_PTP_PPS_ENABLED;
> --
> 2.48.1

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>