netdev - Re: [PATCH net v2] net: airoha: Fix loopback mode configuration for GDM2 port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2ee7a29-97f1-417b-9d32-c9dbdb02fff5@intel.com>
Date: Wed, 8 Oct 2025 16:17:17 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] net: airoha: Fix loopback mode configuration for
 GDM2 port



On 10/8/2025 2:27 AM, Lorenzo Bianconi wrote:
> Add missing configuration for loopback mode in airhoha_set_gdm2_loopback
> routine.
> 
> Fixes: 9cd451d414f6e ("net: airoha: Add loopback support for GDM2")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---
> Changes in v2:
> - Use human readable marcos to configure loopback mode register
> - Link to v1: https://lore.kernel.org/r/20251005-airoha-loopback-mode-fix-v1-1-d017f78acf76@kernel.org
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/airoha/airoha_eth.c  | 4 +++-
>  drivers/net/ethernet/airoha/airoha_regs.h | 3 +++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/airoha/airoha_eth.c b/drivers/net/ethernet/airoha/airoha_eth.c
> index 81ea01a652b9c545c348ad6390af8be873a4997f..833dd911980b3f698bd7e5f9fd9e2ce131dd5222 100644
> --- a/drivers/net/ethernet/airoha/airoha_eth.c
> +++ b/drivers/net/ethernet/airoha/airoha_eth.c
> @@ -1710,7 +1710,9 @@ static void airhoha_set_gdm2_loopback(struct airoha_gdm_port *port)
>  	airoha_fe_wr(eth, REG_GDM_RXCHN_EN(2), 0xffff);
>  	airoha_fe_rmw(eth, REG_GDM_LPBK_CFG(2),
>  		      LPBK_CHAN_MASK | LPBK_MODE_MASK | LPBK_EN_MASK,
> -		      FIELD_PREP(LPBK_CHAN_MASK, chan) | LPBK_EN_MASK);
> +		      FIELD_PREP(LPBK_CHAN_MASK, chan) |
> +		      LBK_GAP_MODE_MASK | LBK_LEN_MODE_MASK |
> +		      LBK_CHAN_MODE_MASK | LPBK_EN_MASK);
>  	airoha_fe_rmw(eth, REG_GDM_LEN_CFG(2),
>  		      GDM_SHORT_LEN_MASK | GDM_LONG_LEN_MASK,
>  		      FIELD_PREP(GDM_SHORT_LEN_MASK, 60) |
> diff --git a/drivers/net/ethernet/airoha/airoha_regs.h b/drivers/net/ethernet/airoha/airoha_regs.h
> index e1c15c20be8e13197de743d9b590dc80058560a5..69c5a143db8c079be0a6ecf41081cd3f5048c090 100644
> --- a/drivers/net/ethernet/airoha/airoha_regs.h
> +++ b/drivers/net/ethernet/airoha/airoha_regs.h
> @@ -151,6 +151,9 @@
>  #define LPBK_LEN_MASK			GENMASK(23, 10)
>  #define LPBK_CHAN_MASK			GENMASK(8, 4)
>  #define LPBK_MODE_MASK			GENMASK(3, 1)
> +#define LBK_GAP_MODE_MASK		BIT(3)
> +#define LBK_LEN_MODE_MASK		BIT(2)
> +#define LBK_CHAN_MODE_MASK		BIT(1)
>  #define LPBK_EN_MASK			BIT(0)
>  
>  #define REG_GDM_TXCHN_EN(_n)		(GDM_BASE(_n) + 0x24)
> 
> ---
> base-commit: 1b54b0756f051c11f5a5d0fbc1581e0b9a18e2bc
> change-id: 20251005-airoha-loopback-mode-fix-3a9c0036017e
> 
> Best regards,



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)