netdev - Re: [PATCH net v2 3/9] eth: fbnic: fix saving stats from XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91d4b9cd-fe8f-4101-9d9b-5fda4d7ca404@intel.com>
Date: Wed, 8 Oct 2025 16:30:40 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <bpf@...r.kernel.org>,
	<alexanderduyck@...com>, <sdf@...ichev.me>, <mohsin.bashr@...il.com>
Subject: Re: [PATCH net v2 3/9] eth: fbnic: fix saving stats from XDP_TX rings
 on close



On 10/7/2025 4:26 PM, Jakub Kicinski wrote:
> When rings are freed - stats get added to the device level stat
> structs. Save the stats from the XDP_TX ring just as Tx stats.
> Previously they would be saved to Rx and Tx stats. So we'd not
> see XDP_TX packets as Rx during runtime but after an down/up cycle
> the packets would appear in stats.
> 
> Correct the helper used by ethtool code which does a runtime
> config switch.
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)