netdev - Re: [PATCH net v2 6/9] eth: fbnic: fix reporting of alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a237d474-715a-4b84-8bbb-0691e4568d13@intel.com>
Date: Wed, 8 Oct 2025 16:33:22 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <bpf@...r.kernel.org>,
	<alexanderduyck@...com>, <mohsin.bashr@...il.com>,
	<vadim.fedorenko@...ux.dev>, <jdamato@...tly.com>,
	<aleksander.lobakin@...el.com>
Subject: Re: [PATCH net v2 6/9] eth: fbnic: fix reporting of alloc_failed
 qstats



On 10/7/2025 4:26 PM, Jakub Kicinski wrote:
> Rx processing under normal circumstances has 3 rings - 2 buffer
> rings (heads, payloads) and a completion ring. All the rings
> have a struct fbnic_ring. Make sure we expose alloc_failed
> counter from the buffer rings, previously only the alloc_failed
> from the completion ring was reported, even tho all ring types
> may increment this counter (buffer rings in __fbnic_fill_bdq()).
> 
> This makes the pp_alloc_fail.py test pass, it expects the qstat
> to be incrementing as page pool injections happen.
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> Fixes: 67dc4eb5fc92 ("eth: fbnic: report software Rx queue stats")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)