netdev - Re: [PATCH] ptp: netc: Add dependency on NXP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251007181903.36a3a345@kernel.org>
Date: Tue, 7 Oct 2025 18:19:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Peter Robinson <pbrobinson@...il.com>
Cc: Richard Cochran <richardcochran@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Frank Li
 <Frank.Li@....com>, Wei Fang <wei.fang@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

On Sun,  5 Oct 2025 21:49:42 +0100 Peter Robinson wrote:
> The NETC V4 Timer PTP IP works with the associated NIC
> so depend on it, plus compile test, and default it on if
> the NIC is enabled similar to the other PTP modules.
> 
> Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")

You put a Fixes tag here, suggesting this is a fix.
What bug is it fixing? Seems like an improvement to the default 
kconfig behavior, TBH. If it is a bug fix please explain in the
commit message more. If not please drop the Fixes tag and repost
next week. Also..

> Signed-off-by: Peter Robinson <pbrobinson@...il.com>
> ---
>  drivers/ptp/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 5f8ea34d11d6d..a5542751216d6 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -255,6 +255,8 @@ config PTP_S390
>  
>  config PTP_NETC_V4_TIMER
>  	tristate "NXP NETC V4 Timer PTP Driver"
> +	depends on NXP_ENETC4 || COMPILE_TEST

.. why? Does the clock driver not work at all without the networking
driver? Or you just think that they go together?

> +	default y if NXP_ENETC4

Isn't this better written as:

	default NXP_ENETC4

?

>  	depends on PTP_1588_CLOCK
>  	depends on PCI_MSI
>  	help