netdev - RE: [PATCH] ptp: netc: Add dependency on NXP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510DADA2C5A2E055C3021DF88EEA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 9 Oct 2025 05:51:11 +0000
From: Wei Fang <wei.fang@....com>
To: Peter Robinson <pbrobinson@...il.com>, Jakub Kicinski <kuba@...nel.org>
CC: Richard Cochran <richardcochran@...il.com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Frank Li
	<frank.li@....com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] ptp: netc: Add dependency on NXP_ENETC4

> > > The NETC V4 Timer PTP IP works with the associated NIC
> > > so depend on it, plus compile test, and default it on if
> > > the NIC is enabled similar to the other PTP modules.
> > >
> > > Fixes: 87a201d59963e ("ptp: netc: add NETC V4 Timer PTP driver support")
> >
> > You put a Fixes tag here, suggesting this is a fix.
> > What bug is it fixing? Seems like an improvement to the default
> > kconfig behavior, TBH. If it is a bug fix please explain in the
> > commit message more. If not please drop the Fixes tag and repost
> > next week. Also..
> 
> I don't believe it works without the associated hardware so it seems
> like a bug to me, There's likely nuance and opinion. I labelled as a
> fix so it lands into the same kernel release as opposed to the next
> one.
> 

The NETC timer and ENETC are two PCIe devices, and the timer
provides PHC for ENETC to use. From hardware perspective, the
timer is PHC supplier and ENETC is the consumer, the timer should
work properly even if ENETC is not working. For example, the timer
can still provide PPS event, outputs periodic pulse signal captures
external timestamps and so on.