netdev - Re: [PATCH v4 3/3] net: usb: ax88179_178a: add USB device driver for config selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251009073450.87902-1-yicongsrfy@163.com>
Date: Thu,  9 Oct 2025 15:34:50 +0800
From: yicongsrfy@....com
To: oneukum@...e.com
Cc: andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	linux-usb@...r.kernel.org,
	marcan@...can.st,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	yicong@...inos.cn
Subject: Re: [PATCH v4 3/3] net: usb: ax88179_178a: add USB device driver for config selection

Hi, Oliver:
Thank you for your reply!

The issues you mentioned above, I will fix them one by one in new patch
versions. However, I'm a bit confused about the following comment:

> > +
> > +static void __exit ax88179_driver_exit(void)
> > +{
> > +	usb_deregister(&ax88179_178a_driver);
>
> The window for the race
>
> > +	usb_deregister_device_driver(&ax88179_cfgselector_driver);
>
> Wrong order. I you remove ax88179_178a_driver before you remove
> ax88179_cfgselector_driver, you'll leave a window during which
> devices would be switched to a mode no driver exists for.

In my init function, I first call usb_register_device_driver and then call
usb_register; in exit, I reverse the order by calling usb_deregister first,
then usb_deregister_device_driver. Why is this sequence considered incorrect?