netdev - Re: [PATCH] net: usb: r8152: add error handling in rtl8152_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251009085255.GU3060232@horms.kernel.org>
Date: Thu, 9 Oct 2025 09:52:55 +0100
From: Simon Horman <horms@...nel.org>
To: yicongsrfy@....com
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	oneukum@...e.com, kuba@...nel.org, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, yicong@...inos.cn
Subject: Re: [PATCH] net: usb: r8152: add error handling in
 rtl8152_driver_init

On Thu, Oct 09, 2025 at 03:58:33PM +0800, yicongsrfy@....com wrote:
> From: Yi Cong <yicong@...inos.cn>
> 
> rtl8152_driver_init missing error handling.
> If cannot register rtl8152_driver, rtl8152_cfgselector_driver
> should be deregistered.
> 
> Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
> Signed-off-by: Yi Cong <yicong@...inos.cn>

Thanks Yi Cong,

I agree that this addresses a bug.
And that the bug was introduced by the cited commit.

Reviewed-by: Simon Horman <horms@...nel.org>

Some points to keep in mind for future patch submissions.
(I don't think you need to repost because of these,
 but others may think otherwise).

1. Please tag Networking patches with the target tree.
   In this case, as a bug fix, that would be net.

   Subject: [PATCH net] ...

   Otherwise it would probably be net-next.

2. Git history is not entirely consistent here, but
   I'd say that 'r8152:' is good prefix for this patch (less is more IMHO).

   Subject: [PATCH net] r8152: ...

3. It is, TBH, not strictly followed for networking patches. But officially
   bug fixes for stable should be CCed to stable@...r.kernel.org. Greg KH
   tends to be CCed on such patches, and has a bot that complains about this.

4. Please generate the CC list using

   ./scripts/get_maintainer.pl this.patch

   Perhaps with --git-min-percent=25

For more information see:
https://docs.kernel.org/process/maintainer-netdev.html

...