netdev - Re: [PATCH v2 net-next 3/3] vhost/net: enable outer nw header offset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c346fd4-3c61-4b31-976a-41a2e2ef0afe@redhat.com>
Date: Thu, 9 Oct 2025 11:44:50 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kommula Shiva Shankar <kshankar@...vell.com>, netdev@...r.kernel.org,
 mst@...hat.com, jasowang@...hat.com, xuanzhuo@...ux.alibaba.com
Cc: virtualization@...ts.linux.dev, parav@...dia.com, jerinj@...vell.com,
 ndabilpuram@...vell.com, sburla@...vell.com, schalla@...vell.com
Subject: Re: [PATCH v2 net-next 3/3] vhost/net: enable outer nw header offset
 support

On 10/8/25 1:00 PM, Kommula Shiva Shankar wrote:
> apprise vhost net about the virtio net header size.
> 
> Signed-off-by: Kommula Shiva Shankar <kshankar@...vell.com>
> ---
>  drivers/vhost/net.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index 35ded4330431..8d055405746d 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -78,6 +78,7 @@ static const u64 vhost_net_features[VIRTIO_FEATURES_DWORDS] = {
>  	(1ULL << VIRTIO_F_IN_ORDER),
>  	VIRTIO_BIT(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO) |
>  	VIRTIO_BIT(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO),
> +	VIRTIO_BIT(VIRTIO_NET_F_OUT_NET_HEADER),

I guess this patch needs better testing; the above triggers a compile
warning:

./drivers/vhost/net.c:81:2: warning: excess elements in array
initializer [-Wexcess-initializers]
   81 |         VIRTIO_BIT(VIRTIO_NET_F_OUT_NET_HEADER),

which in turns hints the feature is not actually used/available. The
chunk should be:

  	VIRTIO_BIT(VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO) |
  	VIRTIO_BIT(VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO)  |
	VIRTIO_BIT(VIRTIO_NET_F_OUT_NET_HEADER),

/P