netdev - Re: [PATCH net v2] r8152: add error handling in rtl8152_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251011012725.502121-1-yicongsrfy@163.com>
Date: Sat, 11 Oct 2025 09:27:25 +0800
From: yicongsrfy@....com
To: andrew@...n.ch
Cc: andrew+netdev@...n.ch,
	davem@...emloft.net,
	edumazet@...gle.com,
	horms@...nel.org,
	kuba@...nel.org,
	linux-usb@...r.kernel.org,
	netdev@...r.kernel.org,
	oneukum@...e.com,
	stable@...r.kernel.org,
	yicong@...inos.cn
Subject: Re: [PATCH net v2] r8152: add error handling in rtl8152_driver_init

On Fri, 10 Oct 2025 15:54:27 +0200, Andrew Lunn <andrew@...n.ch> wrote:
>
> > +
> > +	ret = usb_register(&rtl8152_driver);
> > +	if (ret) {
> > +		usb_deregister_device_driver(&rtl8152_cfgselector_driver);
> > +		return ret;
> > +	}
> > +
> > +	return ret;
>
> Now look at this code and think about it.

Sorry, these two 'return ret' are indeed redundant.
I will submit a new patch version to fix this.